alamb commented on PR #8887: URL: https://github.com/apache/arrow-rs/pull/8887#issuecomment-3576810356
> This test case failed: > > https://github.com/apache/arrow-rs/blob/fea605cb16f7524cb69a197bfa581a1d4f5fe5d0/parquet-variant-compute/src/variant_get.rs#L3754-L3781 > > It is because the perfectly shredded array itself is not a valid arrow array. I'm not sure if this is a well-defined behavior, I didn't check carefully, but I feel it is `Time64MicrosecondArray`'s responsibility to make sure the its data is valid. > > What do you think @alamb @klion26 @friendlymatthew ? Yes, I agree with this assessment. We shouldn't be relying on `variant_get` to detect incorrectly shredded values. In my mind, I expect the cast options to apply when the source is not shredded (aka it is a dynamically typed variant) so "casting" is required as part of `variant_get` Therefore I think we should update the test to either use a non -shredded variant. Here is a test to do so: - https://github.com/apache/arrow-rs/pull/8921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
