alamb commented on code in PR #8887:
URL: https://github.com/apache/arrow-rs/pull/8887#discussion_r2560905183
##########
parquet-variant-compute/src/variant_get.rs:
##########
@@ -3799,4 +3826,18 @@ mod test {
assert!(result.is_null(i));
}
}
+
+ #[test]
+ fn test_perfect_shredding_returns_same_arc_ptr() {
Review Comment:
can you also please add some other tests? Specifically, tests for:
1. The case when the shredded value has all nulls
2. The case when the shredded value has some nulls
3. The case when the shredded value is a Struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
