pitrou commented on code in PR #48207:
URL: https://github.com/apache/arrow/pull/48207#discussion_r2565052177


##########
cpp/src/parquet/statistics.cc:
##########
@@ -925,22 +926,94 @@ void TypedStatisticsImpl<DType>::UpdateSpaced(const T* 
values, const uint8_t* va
 
 template <typename DType>
 void TypedStatisticsImpl<DType>::PlainEncode(const T& src, std::string* dst) 
const {
+#if ARROW_LITTLE_ENDIAN
   auto encoder = MakeTypedEncoder<DType>(Encoding::PLAIN, false, descr_, 
pool_);
   encoder->Put(&src, 1);

Review Comment:
   I'm ok with optimizing/simplifying the encode/decode functions, because it's 
counter-productive to instantiate an encoder/decoder just for a single PLAIN 
value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to