joe-ucp commented on code in PR #8894:
URL: https://github.com/apache/arrow-rs/pull/8894#discussion_r2572605874
##########
parquet/src/bin/parquet-fromcsv.rs:
##########
@@ -445,6 +445,9 @@ mod tests {
let mut actual = String::from_utf8(buffer_vec).unwrap();
let pos = actual.find('\n').unwrap() + 1;
actual = actual[pos..].to_string();
+ // Normalize line endings for cross-platform compatibility
+ let expected = expected.replace("\r\n", "\n").trim_start().to_string();
Review Comment:
Reverted. Restored the original logic to keep this PR scoped to page index
typing only.
##########
parquet/src/arrow/schema/extension.rs:
##########
@@ -36,7 +36,7 @@ use arrow_schema::extension::ExtensionType;
/// Arrow DataType, and instead are represented by an Arrow ExtensionType.
/// Extension types are attached to Arrow Fields via metadata.
pub(crate) fn try_add_extension_type(
- mut arrow_field: Field,
+ #[allow(unused_mut)] mut arrow_field: Field,
Review Comment:
Reverted. Removed #[allow(unused_mut)] and any unrelated tweaks. (Only kept
the minimal import adjustments where strictly required by variant_experimental;
otherwise unchanged.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
