lichuang commented on code in PR #8990:
URL: https://github.com/apache/arrow-rs/pull/8990#discussion_r2617878324
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -107,10 +108,25 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
current_size: STARTING_BLOCK_SIZE,
},
string_tracker: None,
+ max_deduplication_len: None,
phantom: Default::default(),
}
}
+ /// Configure max deduplication length when deduplicating strings while
building the array.
+ /// Default is [`MAX_INLINE_VIEW_LEN`] bytes.
+ /// See <https://github.com/apache/arrow-rs/issues/7187> for more details
on the implications.
+ pub fn with_max_deduplication_len(self, max_deduplication_len: u32) ->
Self {
+ debug_assert!(
Review Comment:
i look at the `with_fixed_block_size` function, it use `debug_assert`:
```
pub fn with_fixed_block_size(self, block_size: u32) -> Self {
debug_assert!(block_size > 0, "Block size must be greater than 0");
Self {
block_size: BlockSizeGrowthStrategy::Fixed { size: block_size },
..self
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
