klion26 commented on code in PR #8990:
URL: https://github.com/apache/arrow-rs/pull/8990#discussion_r2618048494
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -87,6 +87,7 @@ pub struct GenericByteViewBuilder<T: ByteViewType + ?Sized> {
/// Some if deduplicating strings
/// map `<string hash> -> <index to the views>`
string_tracker: Option<(HashTable<usize>, ahash::RandomState)>,
+ max_deduplication_len: Option<u32>,
Review Comment:
Will changing `self.max_deduplication_len` to `u32` and setting the default
value to `MAX_INLINE_VIEW_LEN` be better? After this, we can unify the logic in
L354 to `length < self.max_deduplication_len`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
