mkleen commented on PR #8988: URL: https://github.com/apache/arrow-rs/pull/8988#issuecomment-3669444943
Dear @alamb, I just pushed another version. This just implements the existing `InputGenerator` trait for StringViews and uses the already existing benchmark function generating the following combinations: ``` (null_scalar vs non_null_scalar) (non_null_scalar vs null_scalar) (non_nulls_scalar vs non_nulls_scalar) (array vs non_null_scalar) (non_null_scalar vs array) (array vs array) ``` This does the job to show the improvements of https://github.com/apache/arrow-rs/pull/8963 for the first three combinations in the spirit of https://github.com/apache/arrow-rs/pull/8653 If you prefer to also refactor the benchmarks further with your suggestion regarding the return types of the `InputGenerator`, I am happy to do so, however this would mean I would need to adapt already existing benchmark code. Let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
