Jefffrey commented on code in PR #8988:
URL: https://github.com/apache/arrow-rs/pull/8988#discussion_r2647419985
##########
arrow/src/util/bench_util.rs:
##########
@@ -208,6 +208,39 @@ pub fn
create_string_array_with_len_range_and_prefix_and_seed<Offset: OffsetSize
})
.collect()
}
+/// Creates a string view array of a given range, null density and length
+///
+/// Arguments:
+/// - `size`: number of string view array
+/// - `null_density`: density of nulls in the string view array
+/// - `min_str_len`: minimum size of each string in the string view array
+/// - `max_str_len`: maximum size of each string in the string view array
+/// - `seed`: seed for the random number generator
+pub fn create_string_view_array_with_len_range_and_seed(
+ size: usize,
+ null_density: f32,
+ min_str_len: usize,
+ max_str_len: usize,
Review Comment:
nit: we could just pass in the range here instead of separating it as two
variables
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
