brancz commented on code in PR #9007:
URL: https://github.com/apache/arrow-rs/pull/9007#discussion_r2630388359
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -1229,7 +1237,7 @@ pub fn cast_with_options(
.all(|(f1, f2)| f1.name() == f2.name());
let fields = if fields_match_order {
- // Fast path: cast columns in order
+ // Fast path: cast columns in order if their names match
Review Comment:
Done! That also showed the possibility of deduplicating the "cast in order"
functionality that's used in two of the branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
