alamb commented on code in PR #9007:
URL: https://github.com/apache/arrow-rs/pull/9007#discussion_r2628566677
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -1229,7 +1237,7 @@ pub fn cast_with_options(
.all(|(f1, f2)| f1.name() == f2.name());
let fields = if fields_match_order {
- // Fast path: cast columns in order
+ // Fast path: cast columns in order if their names match
Review Comment:
A minor suggestion would be to pull this code into its own function to make
it easier to read (as this giant match statement is already pretty big)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
