alamb commented on code in PR #9016:
URL: https://github.com/apache/arrow-rs/pull/9016#discussion_r2635967388
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -884,12 +895,15 @@ impl<T: ByteViewType + ?Sized> Array for
GenericByteViewArray<T> {
}
fn shrink_to_fit(&mut self) {
+ /*
Review Comment:
> Is shrink_to_fit a best-effort operation? If so, it's probably not
necessary to try to shrink self.buffers...?
I think it is reasonable behavior. Maybe we can leave a comment explaining
the rationale ('best effort' or something) -- the memory that will be saved
from a few elements in a Vec is not likely high -- especially as slicing a
generic view array doesn't adjust the buffers anyways
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -884,12 +895,15 @@ impl<T: ByteViewType + ?Sized> Array for
GenericByteViewArray<T> {
}
fn shrink_to_fit(&mut self) {
+ /*
Review Comment:
yeah my review overlapped with your push 🏃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
