maxburke commented on code in PR #9016:
URL: https://github.com/apache/arrow-rs/pull/9016#discussion_r2635967788
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -279,7 +290,7 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
}
/// Deconstruct this array into its constituent parts
- pub fn into_parts(self) -> (ScalarBuffer<u128>, Vec<Buffer>,
Option<NullBuffer>) {
+ pub fn into_parts(self) -> (ScalarBuffer<u128>, Arc<[Buffer]>,
Option<NullBuffer>) {
Review Comment:
I've tested it with Datafusion and it dropped right in (both the mainline
version and the hacked up and patched version we're using).
But, yeah, I can't speak for other users of the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
