debugmiller commented on code in PR #9021:
URL: https://github.com/apache/arrow-rs/pull/9021#discussion_r2636492978
##########
arrow-json/src/reader/mod.rs:
##########
@@ -686,12 +789,27 @@ macro_rules! primitive_decoder {
}
fn make_decoder(
+ field: Option<FieldRef>,
Review Comment:
@scovich you commented here on the other PR about it being awkward to take
`Field` and still require `data_type` and `is_nullable`. I agree but the issue
I ran into is that when `ReaderBuilder::build_decoder` calls `make_decoder` on
the root of the schema it creates a Struct based on the Schema to pass in.
Another option here could be to create a dummy Field from the Schema. I'd
have to look at whether `data_type` and `is_nullable` are always inherited from
the field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
