scovich commented on code in PR #9021:
URL: https://github.com/apache/arrow-rs/pull/9021#discussion_r2637409790
##########
arrow-json/src/reader/mod.rs:
##########
@@ -686,12 +789,27 @@ macro_rules! primitive_decoder {
}
fn make_decoder(
+ field: Option<FieldRef>,
Review Comment:
They're not always inherited. Some callers are passing the union of all
ancestors' nullability, i.e. when extracting a nested field from a struct.
That's why I had suggested perhaps just passing the field metadata here --
because I don't think the nullable and data type members of a passed-in Field
would be used, potentially leading to confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
