zanmato1984 commented on PR #47168: URL: https://github.com/apache/arrow/pull/47168#issuecomment-3733040671
I think it becomes more reasonable now to move forward this PR, since: 1. We have officially upgraded to C++20, which already requires a more recent clang (#48414). Actually we are using v18 in our CI ([1] [2]). 2. I added several concepts in #48459 ([3]), which is formatted differently between current v14 (in precommit) and v15+ (in my local). This is quite annoying and I had to manually modify it to match the required v14 format. The clang-format behavior change wrt C++20 concepts can be found in [4] [5]. I've made a commit in this PR with an update to the clang-format version change from v20 to a less aggressive v18, and related code formatting. @kou @pitrou @AntoinePrv what do you think? Thanks. [1] https://github.com/apache/arrow/blob/7fe39d470f6b1fb803772dbb6dccfb4d26af54fe/.github/workflows/cpp.yml#L84 [2] https://github.com/apache/arrow/blob/7fe39d470f6b1fb803772dbb6dccfb4d26af54fe/.env#L60 [3] https://github.com/apache/arrow/blob/3fb84ff2c66deea205b45cad697ab724ea98ad5d/cpp/src/arrow/compute/kernels/hash_aggregate.cc#L283-L285 [4] https://github.com/llvm/llvm-project/issues/56283 [5] https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#clang-format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
