zanmato1984 commented on PR #47168:
URL: https://github.com/apache/arrow/pull/47168#issuecomment-3741537709
> > Is this because we want to have a system that has defaulted
precommit/clang-format that matches the latest requirement?
>
> It's for only pre-commit. We don't need to care about clang-format
version. pre-commit installs clang-format automatically.
Oh, I mean even on older Ubuntu we can still have a recent-enough
pre-commit, right? Why does this have anything to do with the version of
Ubuntu? (Is it because on Ubuntu 24.04, the defaulted pre-commit is
recent-enough, so people don't have to install one?)
> ```diff
> diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
> index b763cfbbbc..59171ddcaa 100644
> --- a/.github/workflows/dev.yml
> +++ b/.github/workflows/dev.yml
> @@ -41,8 +41,8 @@ jobs:
>
> lint:
> name: Lint C++, Python, R, Docker, RAT
> - # Use Ubuntu 22.04 to ensure working pre-commit on Ubuntu 22.04.
> - runs-on: ubuntu-22.04
> + # Use Ubuntu 24.04 to ensure working pre-commit on Ubuntu 24.04.
> + runs-on: ubuntu-24.04
> if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
> timeout-minutes: 15
> steps:
> ```
Thanks a lot! Let me try this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
