scovich commented on code in PR #9156:
URL: https://github.com/apache/arrow-rs/pull/9156#discussion_r2687183575
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -988,9 +988,13 @@ impl<'a, T: ByteViewType + ?Sized> IntoIterator for &'a
GenericByteViewArray<T>
impl<T: ByteViewType + ?Sized> From<ArrayData> for GenericByteViewArray<T> {
fn from(data: ArrayData) -> Self {
- let (_data_type, len, nulls, offset, mut buffers, _child_data) =
data.into_parts();
- let views = buffers.remove(0); // need to maintain order of remaining
buffers
- let buffers = Arc::from(buffers);
+ let (_data_type, len, nulls, offset, buffers, _child_data) =
data.into_parts();
+
+ // first buffer is views
+ let views = buffers[0].clone();
+ // remaining buffers are data buffers
+ let buffers = Arc::from_iter(buffers.into_iter().skip(1));
Review Comment:
nit:
```suggestion
// first buffer is views, remaining buffers are data buffers
let buffers = buffers.into_iter();
let views = buffers.next().unwrap(); // safety: never empty
let buffers = Arc::from_iter(buffers);
```
(question tho -- why do we _know_ `buffers` is never empty?)
Also -- it would be fewer lines of code to fold those two values into the
constructor call?
```rust
let buffers = buffers.into_iter();
Self {
data_type: T::DATA_TYPE,
views: buffers.next().unwrap(),
buffers: Arc::from_iter(buffers),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
