WillAyd commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2690601635
##########
ci/scripts/python_sdist_build.sh:
##########
@@ -23,5 +23,9 @@ source_dir=${1}/python
pushd "${source_dir}"
export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION:-}
-${PYTHON:-python} setup.py sdist
+# Meson dist must be run from a VCS, so initiate a dummy repo
+git init .
+git add --all .
+git commit -m "dummy commit for meson dist"
+${PYTHON:-python} -m build --sdist .
Review Comment:
> I am unsure whether creating the git repo is necessary
It is because building an sdist calls `meson dist` under the hood, which
itself requires to be run from a VCS
> The problem now is that it seems to want to build pyarrow
Try adding `-Csetup-args="-Dsdist=true"` to the invocation. This is
something we encountered previously on this PR, so I added that option (noted
in the top level python/meson.build file and upstream in
https://github.com/mesonbuild/meson-python/issues/647)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
