wgtmac commented on code in PR #48982:
URL: https://github.com/apache/arrow/pull/48982#discussion_r2729827808
##########
cpp/src/parquet/arrow/reader_writer_benchmark.cc:
##########
@@ -778,7 +778,7 @@ static void BM_ReadMultipleRowGroups(::benchmark::State&
state) {
auto arrow_reader = std::move(*arrow_reader_result);
std::shared_ptr<Table> table;
- EXIT_NOT_OK(arrow_reader->ReadRowGroups(rgs, &table));
+ PARQUET_ASSIGN_OR_THROW(table, arrow_reader->ReadRowGroups(rgs));
Review Comment:
```suggestion
PARQUET_ASSIGN_OR_THROW(auto table, arrow_reader->ReadRowGroups(rgs));
```
Let's remove line 780
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -2453,10 +2453,10 @@ TEST(TestArrowReadWrite, ReadSingleRowGroup) {
std::shared_ptr<Table> r1, r2, r3, r4;
// Read everything
- ASSERT_OK_NO_THROW(reader->ReadRowGroup(0, &r1));
+ ASSERT_OK_AND_ASSIGN(r1, reader->ReadRowGroup(0));
Review Comment:
```suggestion
ASSERT_OK_AND_ASSIGN(auto r1, reader->ReadRowGroup(0));
```
We have the chance to remove line 2454
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -2453,10 +2453,10 @@ TEST(TestArrowReadWrite, ReadSingleRowGroup) {
std::shared_ptr<Table> r1, r2, r3, r4;
// Read everything
- ASSERT_OK_NO_THROW(reader->ReadRowGroup(0, &r1));
+ ASSERT_OK_AND_ASSIGN(r1, reader->ReadRowGroup(0));
ASSERT_OK_NO_THROW(reader->RowGroup(1)->ReadTable(&r2));
Review Comment:
Do we have a Result version for this ReadTable call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
