kou commented on code in PR #49032:
URL: https://github.com/apache/arrow/pull/49032#discussion_r2734425379
##########
ci/docker/linux-apt-docs.dockerfile:
##########
@@ -31,11 +31,9 @@ RUN apt-get update -y && \
lsb-release && \
gpg --keyserver keyserver.ubuntu.com \
--recv-key 95C0FAF38DB3CCAD0C080A7BDC78B2DDEABC47B7 && \
- gpg --export 95C0FAF38DB3CCAD0C080A7BDC78B2DDEABC47B7 | \
- gpg --no-default-keyring \
- --keyring /usr/share/keyrings/cran.gpg \
- --import - && \
- echo "deb [signed-by=/usr/share/keyrings/cran.gpg]
https://cloud.r-project.org/bin/linux/$(lsb_release -is | tr 'A-Z' 'a-z')
$(lsb_release -cs)-cran40/" | \
+ gpg --armor --export 95C0FAF38DB3CCAD0C080A7BDC78B2DDEABC47B7 | \
+ tee /etc/apt/trusted.gpg.d/cran_debian_key.asc && \
+ echo "deb https://cloud.r-project.org/bin/linux/$(lsb_release -is | tr
'A-Z' 'a-z') $(lsb_release -cs)-cran40/" | \
Review Comment:
Could you keep using `signed-by` instead of `trusted.gpg.d/`?
`trusted.gpg.d/` is used by all APT repositories. We should use key only for
CRAN's APT repository.
```suggestion
gpg --armor --export 95C0FAF38DB3CCAD0C080A7BDC78B2DDEABC47B7 | \
tee /usr/share/keyrings/cran.asc && \
echo "deb [signed-by=/usr/share/keyrings/cran.asc]
https://cloud.r-project.org/bin/linux/$(lsb_release -is | tr 'A-Z' 'a-z')
$(lsb_release -cs)-cran40/" | \
```
##########
dev/tasks/tasks.yml:
##########
@@ -589,23 +589,25 @@ tasks:
UBUNTU: 22.04
image: ubuntu-python-313-freethreading
- test-debian-12-python-3-amd64:
+{% for debian_version in ["12", "13"] %}
+ test-debian-{{ debian_version }}-python-3-amd64:
ci: github
template: docker-tests/github.linux.yml
params:
env:
- DEBIAN: 12
+ DEBIAN: "{{ debian_version }}"
image: debian-python
- test-debian-12-python-3-i386:
+ test-debian-{{ debian_version }}-python-3-i386:
Review Comment:
Why did you keep them? I think that they are needless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
