kou commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2744754392
##########
dev/release/05-binary-upload.sh:
##########
Review Comment:
We need to add signing command line something like the following here:
```diff
diff --git a/dev/release/05-binary-upload.sh
b/dev/release/05-binary-upload.sh
index f628cce0e0..e66b5af646 100755
--- a/dev/release/05-binary-upload.sh
+++ b/dev/release/05-binary-upload.sh
@@ -98,6 +98,9 @@ upload_to_github_release() {
shasum -a 512 "${base_name}" >"${base_name}.sha512"
popd
fi
+ if [[ "${base_name}" = *.msi ]]; then
+ jsign ... "${dist_dir}/${base_name}"
+ fi
done
gh release upload \
--repo apache/arrow \
```
##########
.github/workflows/cpp_extra.yml:
##########
@@ -478,6 +480,59 @@ jobs:
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
remote_host_key: ${{ secrets.NIGHTLIES_RSYNC_HOST_KEY }}
+ odbc-check-tags:
Review Comment:
Why do we need this?
Can we use the following `if:` in `odbc-release`?
```yaml
if: github.ref_type == 'tag' && contains(github.ref_name, '*-rc*')
```
or
```yaml
if: github.ref_type == 'tag'
```
and
```diff
diff --git a/.github/workflows/cpp_extra.yml
b/.github/workflows/cpp_extra.yml
index 49995752fa..9edec1f46b 100644
--- a/.github/workflows/cpp_extra.yml
+++ b/.github/workflows/cpp_extra.yml
@@ -43,7 +43,7 @@ on:
- 'format/Flight.proto'
- 'testing'
tags:
- - '**'
+ - 'apache-arrow-*-rc*'
pull_request:
paths:
- '.dockerignore'
```
##########
.github/workflows/cpp_extra.yml:
##########
@@ -457,6 +457,25 @@ jobs:
name: flight-sql-odbc-msi-installer
path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
if-no-files-found: error
+ - name: Install ODBC MSI
+ shell: cmd
Review Comment:
Can we use the default PowerShell instead of `cmd`?
##########
dev/release/04-binary-download.sh:
##########
@@ -46,13 +46,14 @@ tag="apache-arrow-${version_with_rc}"
archery crossbow download-artifacts --no-fetch ${CROSSBOW_JOB_ID} "$@"
-# Download Linux packages.
+# Download Linux packages and ODBC MSI.
gh release download "${tag}" \
--dir "packages/${CROSSBOW_JOB_ID}" \
--pattern "almalinux-*.tar.gz" \
--pattern "amazon-linux-*.tar.gz" \
--pattern "centos-*.tar.gz" \
--pattern "debian-*.tar.gz" \
--pattern "ubuntu-*.tar.gz" \
+ --pattern "Apache.Arrow.Flight.SQL.ODBC-*-win64.msi" \
Review Comment:
Can we avoid using spaces in MSI file name?
e.g.: `apache-arrow-flight-sql-odbc-${VERSION}-win64.msi`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
