alinaliBQ commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2761630300
##########
.github/workflows/cpp_extra.yml:
##########
@@ -478,6 +480,59 @@ jobs:
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
remote_host_key: ${{ secrets.NIGHTLIES_RSYNC_HOST_KEY }}
+ odbc-check-tags:
Review Comment:
This check is added for checking tag before the upload to GitHub release. It
works like a simpler `check_labels.yml` for tags.
I think if we apply the change below, it will change the entire C++ Extra
workflow to only be triggered by `apache-arrow-*-rc*` tags, and we want tags
like `C++ Extra` to trigger the workflow as well.
```
tags:
- - '**'
+ - 'apache-arrow-*-rc*'
```
I think the `contains(github.ref_name, '*-rc*')` check is less strict
compared to the current implementation, which I am leaning towards
##########
dev/release/05-binary-upload.sh:
##########
Review Comment:
Thanks for the suggestion @kou. My understanding is that this change will be
done by a PMC member outside of this PR. Please correct me if that’s not the
case
##########
dev/release/04-binary-download.sh:
##########
@@ -46,13 +46,14 @@ tag="apache-arrow-${version_with_rc}"
archery crossbow download-artifacts --no-fetch ${CROSSBOW_JOB_ID} "$@"
-# Download Linux packages.
+# Download Linux packages and ODBC MSI.
gh release download "${tag}" \
--dir "packages/${CROSSBOW_JOB_ID}" \
--pattern "almalinux-*.tar.gz" \
--pattern "amazon-linux-*.tar.gz" \
--pattern "centos-*.tar.gz" \
--pattern "debian-*.tar.gz" \
--pattern "ubuntu-*.tar.gz" \
+ --pattern "Apache.Arrow.Flight.SQL.ODBC-*-win64.msi" \
Review Comment:
Yes good point, I have changed to use hyphens instead of spaces
##########
.github/workflows/cpp_extra.yml:
##########
@@ -457,6 +457,25 @@ jobs:
name: flight-sql-odbc-msi-installer
path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
if-no-files-found: error
+ - name: Install ODBC MSI
+ shell: cmd
Review Comment:
Sure, I have changed to use PowerShell, just curious if it’s for consistency
or if there’s other reasoning behind it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
