scoder commented on issue #49138: URL: https://github.com/apache/arrow/issues/49138#issuecomment-3851000076
Thanks for notifying us. It seems a good thing that you tested with a nightly and it's probably worth keeping that, at least as an "allowed to fail" build job or regular out of band run. I don't see why Python string comparisons work without the GIL and it's an oversight that this wasn't detected before. The old string comparison code that we used was this: https://github.com/cython/cython/pull/7477/files#diff-d38ed1f4a00909a7d38713c9927577f6a2be71c88e248ce55694f9e3020da5bf It's not nogil-compatible outside of CPython (e.g. PyPy or the Limited API) and probably crashes also in CPython when you compare a Unicode string to another known builtin type (which is unlikely to occur in real code because it always raises an exception). Cython should have rejected this comparison in a `nogil` section. I created https://github.com/cython/cython/issues/7500 for that. The fix on your side is simple, just move the option setting line out of the `with nogil:` block. It's the right thing to do, regardless of the Cython version used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
