alamb commented on code in PR #633:
URL:
https://github.com/apache/arrow-rs-object-store/pull/633#discussion_r2769529134
##########
src/aws/checksum.rs:
##########
@@ -24,12 +24,15 @@ use std::str::FromStr;
pub enum Checksum {
/// SHA-256 algorithm.
SHA256,
+ /// CRC64-NVME algorithm.
+ CRC64NVME,
Review Comment:
Yeah, we would have to wait for the next breaking object store release. We
could discuss making such a change and quickly release 0.14 (next breaking
change) if needed
##########
src/aws/checksum.rs:
##########
@@ -24,12 +24,15 @@ use std::str::FromStr;
pub enum Checksum {
Review Comment:
I double checked and indeed CRC64NVME seems to be the default suggestion:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html
Seems like it was added to the official SDK about a year ago:
- https://github.com/awslabs/aws-sdk-rust/issues/1240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
