rluvaton commented on code in PR #9357:
URL: https://github.com/apache/arrow-rs/pull/9357#discussion_r2769572896
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -187,8 +187,11 @@ pub struct ArrowWriter<W: Write> {
/// Creates new [`ArrowRowGroupWriter`] instances as required
row_group_writer_factory: ArrowRowGroupWriterFactory,
- /// The length of arrays to write to each row group
- max_row_group_size: usize,
+ /// The maximum number of rows to write to each row group, or None for
unlimited
+ max_row_group_row_count: Option<usize>,
+
+ /// The maximum size in bytes for a row group, or None for unlimited
+ max_row_group_bytes: Option<usize>,
Review Comment:
can they both be None?
##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -187,8 +187,11 @@ pub struct ArrowWriter<W: Write> {
/// Creates new [`ArrowRowGroupWriter`] instances as required
row_group_writer_factory: ArrowRowGroupWriterFactory,
- /// The length of arrays to write to each row group
- max_row_group_size: usize,
+ /// The maximum number of rows to write to each row group, or None for
unlimited
+ max_row_group_row_count: Option<usize>,
+
+ /// The maximum size in bytes for a row group, or None for unlimited
+ max_row_group_bytes: Option<usize>,
Review Comment:
can they both be None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
