yonipeleg33 commented on code in PR #9357:
URL: https://github.com/apache/arrow-rs/pull/9357#discussion_r2771029203
##########
parquet/src/file/properties.rs:
##########
@@ -575,7 +595,34 @@ impl WriterPropertiesBuilder {
/// If the value is set to 0.
pub fn set_max_row_group_size(mut self, value: usize) -> Self {
Review Comment:
I do agree that this API should be deprecated. Thanks for pointing it out!
> this is a breaking change, as clippy will fail for users
This is inherently _not_ a breaking change; the purpose of marking APIs as
deprecated is to warn users _before_ making a breaking change, without actually
making this change.
This PR already calls for a minor bump due to the new APIs introduced;
deprecating the old one does not change the version semantics for this PR.
> it might be in a different pr
I don't mind either way: Leaving it here or opening a new PR for deprecating
the old API. LMK what's your preference and I'll do it.
> if you keep it please update the pr description under changes to users
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
