projjal commented on a change in pull request #9861:
URL: https://github.com/apache/arrow/pull/9861#discussion_r623607724
##########
File path: cpp/src/gandiva/function_registry_string.cc
##########
@@ -225,6 +225,67 @@ std::vector<NativeFunction> GetStringFunctionRegistry() {
"convert_replace_invalid_fromUTF8_binary",
NativeFunction::kNeedsContext),
+ NativeFunction("convert_todouble", {}, DataTypeVector{float64()},
binary(),
Review comment:
I said function_names are not case-sensitive. So you don't need to have
both upper case and lower case variants, only one would do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
