lidavidm commented on code in PR #3947:
URL: https://github.com/apache/arrow-adbc/pull/3947#discussion_r2785458928
##########
dev/release/utils-prepare.sh:
##########
@@ -98,6 +98,8 @@ update_versions() {
sed -i.bak -E "s/release = \".+\"/release = \"${docs_version}\"/g"
"${ADBC_DIR}/docs/source/conf.py"
rm "${ADBC_DIR}/docs/source/conf.py.bak"
+ sed -i.bak -E "s/latest_release = \".+\"/latest_release =
\"${docs_version}\"/g" "${ADBC_DIR}/docs/source/conf.py"
+ rm "${ADBC_DIR}/docs/source/conf.py.bak"
Review Comment:
I think this will work on release, but won't work on dev, right?
`docs_version` will be `24 (dev)`. I think up top, we need to check if this is
a release or snapshot; if snapshot use PREVIOUS_RELEASE from versions.env, else
use RELEASE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
