Copilot commented on code in PR #49211:
URL: https://github.com/apache/arrow/pull/49211#discussion_r2785684118
##########
cpp/src/arrow/meson.build:
##########
@@ -141,6 +141,7 @@ arrow_components = {
'extension_type.cc',
'extension/bool8.cc',
'extension/json.cc',
+ 'extension/parquet_variant.cc',
'extension/uuid.cc',
Review Comment:
Meson currently installs only a fixed list of headers for `arrow/extension`
(see `cpp/src/arrow/extension/meson.build`), and `parquet_variant.h` isn’t in
that list. After adding `extension/parquet_variant.cc` to the build here,
`meson install` will still omit the public header, which makes downstream
includes like `#include "arrow/extension/parquet_variant.h"` fail for
Meson-based installations. Please also update the Meson header install list
(and any related extension test lists if applicable) to include
`parquet_variant.h` so Meson matches CMake’s
`arrow_install_all_headers("arrow/extension")` behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
