alamb commented on PR #8496:
URL: https://github.com/apache/arrow-rs/pull/8496#issuecomment-3886920629
> @alamb so can you please assign the relevant people, so we can merge this
4 months old PR
I can't assign anyone as I have no actual authority over anyone's time --
All I can do is to beg and/or cajole others into helping do so.
One thing that would help me review this pr (and perhaps others as well) is
a more complete description / documentation of what this code does, with
examples, as I am not all that familiar with the current schema representation
of lists (and not at all familiar with the older one) would to help provide
context (ideally in comments) of what this PR is doing
For example, for me to understand comments like this, I need to go into the
referenced URL and then try and match the terminology used there to what is
used in this repo and PR. While I can do that it will take time and time is
the thing I seem to have the least of
```rust
/// This is used to convert [deprecated repeated columns] (not in a
list), into their arrow representation
```
Maybe it could give an example so that the code was more self contained. For
example, an example of the current List representation and the old (deprecated)
representation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
