etseidl commented on PR #8496:
URL: https://github.com/apache/arrow-rs/pull/8496#issuecomment-3888070352
I'm trying to come up to speed on this, but an early observation is that one
test
(`backward_compat_list_struct_with_nested_repeated_primitive_respects_arrow_hint`)
appears to violate this line in the spec:
> For all fields in the schema, implementations should use either LIST and
MAP annotations or unannotated repeated fields, but not both. When using the
annotations, no unannotated repeated types are allowed.
From the test in question:
```rust
// This is a backward-compatible LIST (rule 4) where the struct
element contains
// a repeated primitive. The arrow hint specifies that the inner
repeated primitive
// should be LargeList<Int32>.
let message_type = "
message schema {
optional group my_list (LIST) {
repeated group my_list_tuple {
required binary str (STRING);
repeated int32 values;
}
}
}
";
```
That said, plugging the tests from this PR into `main` without the fix
yields
```
failures:
arrow::schema::complex::tests::backward_compat_list_struct_with_nested_repeated_primitive_respects_arrow_hint
arrow::schema::complex::tests::convert_schema_with_nested_repeated_struct_and_primitives
arrow::schema::complex::tests::convert_schema_with_repeated_primitive_should_use_inferred_schema
arrow::schema::complex::tests::convert_schema_with_repeated_primitive_should_use_inferred_schema_for_list_as_well
arrow::schema::complex::tests::convert_schema_with_repeated_struct_and_inferred_schema
arrow::schema::complex::tests::convert_schema_with_repeated_struct_and_inferred_schema_and_field_id
test result: FAILED. 24 passed; 6 failed; 0 ignored; 0 measured; 918
filtered out; finished in 0.64s
```
Other than the test mentioned above, the other failing tests seem like they
should succeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
