Jefffrey commented on code in PR #9373:
URL: https://github.com/apache/arrow-rs/pull/9373#discussion_r2796562630
##########
arrow-select/src/interleave.rs:
##########
@@ -426,20 +429,21 @@ fn interleave_fallback_dictionary<K:
ArrowDictionaryKeyType>(
let any_nulls = dictionaries.iter().any(|d| d.keys().nulls().is_some());
let (new_keys, nulls) = if any_nulls {
let mut has_nulls = false;
- let new_keys: Vec<K::Native> = indices
+ let new_keys: Result<Vec<K::Native>, ArrowError> = indices
Review Comment:
I don't think these changes are strictly necessary? Especially as the
docstring of the function already states the callers should verify this can't
happen beforehand
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
