scovich commented on code in PR #9426:
URL: https://github.com/apache/arrow-rs/pull/9426#discussion_r2831217205
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -110,6 +110,19 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
self.offsets_builder.push(self.next_offset());
}
+ /// Appends a value of type `T` into the builder `n` times.
+ ///
+ /// See [`Self::append_value`] for more panic information.
+ #[inline]
+ pub fn append_value_n(&mut self, value: impl AsRef<T::Native>, n: usize) {
+ let bytes = value.as_ref().as_ref();
+ for _ in 0..n {
+ self.value_builder.extend_from_slice(bytes);
Review Comment:
Is that directly related to this PR? Or a more general observation?
AFAIK, rust container allocations _are_ amortized, e.g.
[Vec](https://doc.rust-lang.org/std/vec/struct.Vec.html#guarantees) docs state:
> Vec does not guarantee any particular growth strategy when reallocating
when full, nor when reserve is called. The current strategy is basic and it may
prove desirable to use a non-constant growth factor. Whatever strategy is used
will of course guarantee O(1) amortized push.
So hopefully that's enough to avoid quadratic silliness even if we don't
reserve, leaving only constant factors on the table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
