Dandandan commented on code in PR #9426:
URL: https://github.com/apache/arrow-rs/pull/9426#discussion_r2832214642
##########
arrow-array/src/builder/generic_bytes_builder.rs:
##########
@@ -110,6 +110,19 @@ impl<T: ByteArrayType> GenericByteBuilder<T> {
self.offsets_builder.push(self.next_offset());
}
+ /// Appends a value of type `T` into the builder `n` times.
+ ///
+ /// See [`Self::append_value`] for more panic information.
+ #[inline]
+ pub fn append_value_n(&mut self, value: impl AsRef<T::Native>, n: usize) {
+ let bytes = value.as_ref().as_ref();
+ for _ in 0..n {
+ self.value_builder.extend_from_slice(bytes);
+ self.offsets_builder.push(self.next_offset());
Review Comment:
If you want to make it faster:
`self.offsets_builder.append_trusted_len_iter(` could be used outside of the
loop with an offset iterator.
IMO, also a `reserve` should be added here as this is a builder API - it
makes not really sense in most cases to use a builder if you know the capacity
upfront (you can build the array directly, which will be faster anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
