kou commented on code in PR #4076:
URL: https://github.com/apache/arrow-adbc/pull/4076#discussion_r2922716459
##########
.github/workflows/packaging.yml:
##########
@@ -1226,6 +1231,37 @@ jobs:
path: |
adbc/javascript/*.tgz
+ upload-npm:
+ name: "Upload Node.js packages to npm"
+ runs-on: ubuntu-latest
+ if: github.ref == 'refs/heads/main' && (github.event.schedule ||
inputs.upload_npm)
+ needs:
+ - node-dist
+ environment: npm
+ steps:
+ - uses: actions/checkout@v6
+ with:
+ fetch-depth: 0
+ persist-credentials: false
+
+ - name: Download Node.js packages
+ uses: actions/download-artifact@v8
+ with:
+ name: node-packages
+ path: packages
+
+ - name: Setup Node
+ uses: actions/setup-node@v4
+ with:
+ node-version: 24
+ registry-url: 'https://registry.npmjs.org'
+
+ - name: Publish to npm
+ env:
+ NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
Review Comment:
Does this mean that we need to set npm token to GitHub Actions?
We don't want to do this for now. We want to push to npm from local not on
GitHub Actions.
See also:
* https://github.com/apache/arrow-adbc/issues/4051#issuecomment-4034437685
* https://github.com/apache/arrow-adbc/issues/4051#issuecomment-4034964136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
