lidavidm commented on code in PR #4076:
URL: https://github.com/apache/arrow-adbc/pull/4076#discussion_r2921764590
##########
.github/workflows/packaging.yml:
##########
@@ -1219,13 +1224,44 @@ jobs:
done
- name: Upload Node.js packages
- uses: actions/upload-artifact@v5
+ uses: actions/upload-artifact@v7
with:
name: node-packages
retention-days: 7
path: |
adbc/javascript/*.tgz
+ upload-npm:
+ name: "Upload Node.js packages to npm"
+ runs-on: ubuntu-latest
+ if: github.ref == 'refs/heads/main' && (github.event.schedule ||
inputs.upload_npm)
Review Comment:
If this is for nightly builds, can we use the same trigger as upload-gemfury
instead of having a separate trigger for Node.js?
##########
dev/release/post-09-npm.sh:
##########
Review Comment:
Can we add instructions to
https://github.com/apache/arrow-adbc/blob/main/docs/source/development/releasing.rst?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
