zeroshade commented on code in PR #4080:
URL: https://github.com/apache/arrow-adbc/pull/4080#discussion_r2927656001
##########
c/driver_manager/adbc_driver_manager_profiles.cc:
##########
@@ -278,9 +204,80 @@ struct ProfileVisitor {
};
// Public implementations (non-static for use across translation units)
-AdbcStatusCode ProcessProfileValue(std::string_view value, std::string& out,
- struct AdbcError* error) {
- return ProcessProfileValueInternal(value, out, error);
+AdbcStatusCode ProcessProfileValue(std::string_view key, std::string_view
value,
+ std::string& out, struct AdbcError* error) {
Review Comment:
why the change to add the key here? I don't think it's being used at all
either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
