sdf-jkl commented on code in PR #9518:
URL: https://github.com/apache/arrow-rs/pull/9518#discussion_r2940919512
##########
parquet-variant-compute/src/shred_variant.rs:
##########
@@ -1147,7 +1147,6 @@ mod tests {
}
#[test]
- // TODO(#9518): Drop this once variant_get tests build shredded fixtures
via shred_variant.
Review Comment:
I realized the tests we use in `variant_get.rs` create a perfectly shredded
array, so it's not doing full multi type validation.
We should keep the `shred_variant.rs` tests as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
