edponce commented on a change in pull request #10196:
URL: https://github.com/apache/arrow/pull/10196#discussion_r626092388
##########
File path: r/R/expression.R
##########
@@ -56,13 +56,9 @@ build_array_expression <- function(FUN,
args = list(...),
options = empty_named_list()) {
if (FUN == "-" && length(args) == 1L) {
- # Unary -, i.e. just make it negative, and somehow this works
if (inherits(args[[1]], c("ArrowObject", "array_expression"))) {
- # Make it be 0 - arg
- # TODO(ARROW-11950): do this in C++ compute
- args <- list(0L, args[[1]])
+ return(build_array_expression("negate", args[[1]]))
Review comment:
I would think that using the *checked* versions for language bindings is
more desirable as you want errors to be triggered ASAP. The *unchecked*
versions should be used knowing the wrap around behavior may occur. I think of
it as *unchecked = safe math* and *checked = true math*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
