thisisnic commented on code in PR #49610:
URL: https://github.com/apache/arrow/pull/49610#discussion_r3002782408
##########
cpp/src/arrow/filesystem/s3fs_test.cc:
##########
@@ -431,12 +431,6 @@ TEST_F(S3RegionResolutionTest, PublicBucket) {
ResolveS3BucketRegion("aws-earth-mo-atmospheric-ukv-prd"));
}
-TEST_F(S3RegionResolutionTest, RestrictedBucket) {
- ASSERT_OK_AND_EQ("us-west-2", ResolveS3BucketRegion("ursa-labs-r-test"));
- // Same again, cached
- ASSERT_OK_AND_EQ("us-west-2", ResolveS3BucketRegion("ursa-labs-r-test"));
-}
Review Comment:
Not 100% sure about this - the PublicBucket test still covers region
resolution and caching - we just lose coverage of the specific
403-with-region-header code path, but I can set up another restricted bucket if
this specific but is important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
