etseidl commented on code in PR #9697: URL: https://github.com/apache/arrow-rs/pull/9697#discussion_r3077030332
########## parquet/src/util/push_buffers.rs: ########## @@ -26,18 +26,29 @@ use std::ops::Range; /// This is the in-memory buffer for the ParquetDecoder and ParquetMetadataDecoders /// /// Features: -/// 1. Zero copy -/// 2. non contiguous ranges of bytes +/// 1. Non-contiguous ranges of bytes +/// 2. Stitching: reads that span multiple contiguous physical buffers are +/// resolved transparently. When a single buffer covers the request, the +/// result is zero-copy ([`Bytes::slice`]). When multiple buffers must be +/// stitched, the data is copied into a new allocation. /// -/// # Non Coalescing +/// # No Coalescing /// -/// This buffer does not coalesce (merging adjacent ranges of bytes into a -/// single range). Coalescing at this level would require copying the data but -/// the caller may already have the needed data in a single buffer which would -/// require no copying. +/// This buffer does not coalesce (merging adjacent ranges of bytes into a ingle Review Comment: ```suggestion /// This buffer does not coalesce (merging adjacent ranges of bytes into a single ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
