HippoBaro commented on code in PR #9697:
URL: https://github.com/apache/arrow-rs/pull/9697#discussion_r3080451632
##########
parquet/src/arrow/push_decoder/mod.rs:
##########
@@ -366,13 +369,31 @@ impl ParquetPushDecoder {
self.state.buffered_bytes()
}
- /// Clear any staged byte ranges currently buffered for future decode work.
+ /// Release all staged byte ranges currently buffered for future decode
+ /// work.
///
- /// This clears byte ranges still owned by the decoder's internal
+ /// This releases byte ranges still owned by the decoder's internal
/// `PushBuffers`. It does not affect any data that has already been handed
/// off to an active [`ParquetRecordBatchReader`].
+ pub fn release_all(&mut self) {
+ self.state.release_all();
+ }
+
+ /// Use [`Self::release_all`] instead.
+ #[deprecated(since = "58.1.0", note = "Use `release_all` instead")]
pub fn clear_all_ranges(&mut self) {
Review Comment:
Honestly, we can keep the symbol—it’s just a rename. I’m trying not to
expose the concept of “ranges” on the release side, since the watermark
mechanism supersedes it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
