HippoBaro commented on code in PR #9653:
URL: https://github.com/apache/arrow-rs/pull/9653#discussion_r3090016825
##########
parquet/src/column/writer/mod.rs:
##########
@@ -328,6 +314,77 @@ impl<T: Default> ColumnMetrics<T> {
}
}
+#[derive(Debug, Clone, Copy)]
+pub(crate) enum LevelDataRef<'a> {
Review Comment:
`LevelDataRef` is to `LevelData` what `&str` is to `String`. We need both
because `ArrayLevels` owns its level data
(`LevelData::Materialized(Vec<i16>)`), but `write_batch_internal` must also
accept borrowed `&[i16]` slices from the public `write_batch` API without
allocating.
Even if we could change the public interface, that seems fundamental.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
