etseidl commented on PR #9769: URL: https://github.com/apache/arrow-rs/pull/9769#issuecomment-4284485710
Thanks for your submission @sahuagin. A quick look at this leads me to believe there are 3 PRs here. One to optimize a special skip case, one to optimize for the case of skipping to the end of a page, and one to introduce a new API (`scan_filtered`). Would you be willing to split this PR up accordingly? In particular, the diffs for the `scan_filtered` addition spill over into the other optimizations, making it difficult to see what is actually being changed. Also, if possible, please add new issues as necessary and link to them in the PR description. This helps us greatly when generating release notes. The skip optimization could perhaps piggyback on #9476, but the terminal skip and `scan_filtered` would ideally have their own issues. Finally, if any of this code has been generated by a LLM, please see https://arrow.apache.org/docs/dev/developers/overview.html#ai-generated-code as well as https://www.apache.org/legal/generative-tooling.html Thanks again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
