pitrou commented on code in PR #49663:
URL: https://github.com/apache/arrow/pull/49663#discussion_r3115943905
##########
cpp/src/arrow/util/logging.cc:
##########
@@ -67,7 +68,7 @@ class CerrLog {
virtual ~CerrLog() {
if (has_logged_) {
- std::cerr << std::endl;
+ std::cerr << buffer_.str() << std::endl;
Review Comment:
Did you check whether this is sufficient or a mutex is also required?
You can add a multi-threaded test to `logging_test.cc` so that we can
visually confirm this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
