alinaliBQ commented on code in PR #49585:
URL: https://github.com/apache/arrow/pull/49585#discussion_r3126441804
##########
testing:
##########
Review Comment:
Can we restore the `testing` folder?
##########
cpp/src/arrow/flight/sql/odbc/tests/CMakeLists.txt:
##########
@@ -42,38 +42,38 @@ set(ARROW_FLIGHT_SQL_ODBC_TEST_SRCS
# GH-46889: move protobuf_test_util to a more common location
../../../../engine/substrait/protobuf_test_util.cc)
-# GH-49651 Link ODBC tests statically on Linux and dynamically on macOS/Windows
-if(WIN32 OR APPLE)
- set(ARROW_FLIGHT_SQL_ODBC_TEST_LINK_LIBS arrow_flight_sql_odbc_shared
- ${ARROW_TEST_SHARED_LINK_LIBS})
-else()
- # GH-49651 Link ODBC tests statically on Linux to fix segfault
+if(ARROW_TEST_LINKAGE STREQUAL "static")
Review Comment:
Could we keep the dynamic linking on macOS and static linking on Linux? The
change was needed for GH-49651.
```suggestion
# GH-49651 Link ODBC tests statically on Linux and dynamically on macOS.
# Both static and dynamic linking are supported on Windows
if(APPLE OR (WIN32 AND ARROW_TEST_LINKAGE STREQUAL "shared"))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
