CurtHagenlocher commented on PR #329: URL: https://github.com/apache/arrow-dotnet/pull/329#issuecomment-4322221400
> I saw you made a [comment](https://github.com/apache/arrow-dotnet/pull/328#issuecomment-4317755507) about wanting to refactor `VariantValueWriter` before adding shredding support, but I'm not sure how this helps with shredding. There is shredding-related code which needs to write a `ReadOnlySpan<byte>` and because `VariantValueWriter` used a `MemoryStream` the span needed to be materialized into an array first. This got me to change how `VariantValueWriter` works, and in doing so I realized that the existing pooled arrays it used were very susceptible to leaking. I have a bias towards fixing already-checked-in code before adding new code, so I submitted this PR first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
