CurtHagenlocher commented on code in PR #340:
URL: https://github.com/apache/arrow-dotnet/pull/340#discussion_r3150053906
##########
test/Apache.Arrow.Benchmarks/ArrowReaderBenchmark.cs:
##########
@@ -29,16 +29,22 @@ namespace Apache.Arrow.Benchmarks
[MemoryDiagnoser]
public class ArrowReaderBenchmark
{
- [Params(10_000, 1_000_000)]
+ [Params(10_000, 100_000)]
Review Comment:
Why did this need to change? Because there are more columns in the batch?
##########
src/Apache.Arrow/Ipc/ArrowStreamReaderImplementation.cs:
##########
@@ -316,5 +512,6 @@ public ReadResult(int messageLength, RecordBatch batch)
Batch = batch;
}
}
+
Review Comment:
nit: remove added blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
