CurtHagenlocher commented on code in PR #342:
URL: https://github.com/apache/arrow-dotnet/pull/342#discussion_r3161571607
##########
src/Apache.Arrow.Scalars/Variant/VariantValue.cs:
##########
@@ -109,17 +109,12 @@ public static VariantValue FromDecimal4(decimal value) =>
public static VariantValue FromDecimal8(decimal value) =>
new VariantValue(VariantPrimitiveType.Decimal8, (object)value);
- /// <summary>Creates a Decimal16 variant value.</summary>
- public static VariantValue FromDecimal16(decimal value) =>
- new VariantValue(VariantPrimitiveType.Decimal16, (object)value);
-
/// <summary>
- /// Creates a Decimal16 variant value from a <see cref="SqlDecimal"/>,
always
- /// producing <see cref="VariantPrimitiveType.Decimal16"/>. Values
exceeding
- /// <see cref="decimal"/> range are stored as <see cref="SqlDecimal"/>.
- /// Use this when the target type is known (e.g. materializing a
Decimal16
- /// shredded column); use <see cref="FromSqlDecimal(SqlDecimal)"/>
when you
- /// want the smallest decimal type that fits the value.
+ /// Creates a Decimal16 variant value. Decimal16 covers the full
Parquet
+ /// 38-digit decimal range, which exceeds the <see cref="decimal"/>
96-bit
+ /// mantissa, so the API uses <see cref="SqlDecimal"/> uniformly. Use
+ /// <see cref="FromSqlDecimal(SqlDecimal)"/> when you want the smallest
+ /// decimal type that fits the value.
/// </summary>
public static VariantValue FromDecimal16(SqlDecimal value)
{
Review Comment:
This isn't an issue due to an implicit conversion operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
