CurtHagenlocher commented on code in PR #342:
URL: https://github.com/apache/arrow-dotnet/pull/342#discussion_r3164810048
##########
src/Apache.Arrow.Scalars/Variant/VariantValue.cs:
##########
@@ -152,37 +143,47 @@ public static VariantValue FromDecimal(decimal value)
{
return FromDecimal8(value);
}
- return FromDecimal16(value);
+ return new VariantValue(VariantPrimitiveType.Decimal16,
(object)value);
Review Comment:
Thanks! This is a great example of why the previous implementation (where it
could store either) was just broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
